Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes duplicate badges on marine recruiter surv #7160

Conversation

deathrobotpunch
Copy link
Contributor

@deathrobotpunch deathrobotpunch commented Sep 13, 2024

About the pull request

fixes issue #7011
removes extra rank pin

Explain why it's good for the game

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
fix: fixes duplicate rank pins on marine recruiter survivor
/:cl:

@cmss13-ci cmss13-ci bot added the Fix Fix one bug, make ten more label Sep 13, 2024
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong button, this would just cause for them to only spawn in with the incorrect pin. you can make a new proc on the parent type /datum/eqipment_preset/survivor/uscm which would usually just give the e2 pin, and override it here to give the e5 pin instead

@harryob harryob marked this pull request as draft September 16, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants